Re: [HACKERS] advanced partition matching algorithm for partition-wise join

From: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
To: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
Cc: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Antonin Houska <ah(at)cybertec(dot)at>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, ashutosh(dot)bapat(dot)oss(at)gmail(dot)com
Subject: Re: [HACKERS] advanced partition matching algorithm for partition-wise join
Date: 2018-11-26 12:41:06
Message-ID: CA+q6zcUh5VoTvL5P5NRiN31V3FNFgwUaTjD=upmXLs5=gie2nQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

> On Sun, Nov 25, 2018 at 10:07 PM Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> wrote:
>
> This turned red on cfbot because I turned on -Werror:
>
> partbounds.c: In function ‘partition_bounds_merge’:
> partbounds.c:3619:43: error: ‘outer_part’ may be used uninitialized in
> this function [-Werror=maybe-uninitialized]
> merged_index = map_and_merge_partitions(outer_pmap, outer_mmap,
> ^
> partbounds.c:3475:6: note: ‘outer_part’ was declared here
> int outer_part;
> ^
> cc1: all warnings being treated as errors

Thanks, I've messed this up too - rebased a wrong branch, the correct one
doesn't have this code already. Sorry for that, and here is the proper version
of this patch.

Attachment Content-Type Size
0002-Targetlist-of-a-child-join-is-produced-by-translating-v14.patch application/octet-stream 3.5 KB
0003-Partition-wise-join-for-1-1-1-0-0-1-partition-matching-v14.patch application/octet-stream 69.5 KB
0001-Hash-partition-bound-equality-refactoring-v14.patch application/octet-stream 5.1 KB
0004-Tests-for-0-1-1-1-and-1-0-partition-matching-v14.patch application/octet-stream 218.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dmitry Dolgov 2018-11-26 12:55:07 Re: SQL/JSON: JSON_TABLE
Previous Message Dmitry Dolgov 2018-11-26 12:37:13 Re: [HACKERS] [PATCH] Generic type subscripting