Re: [HACKERS] [PATCH] Generic type subscripting

From: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Oleksandr Shulgin <oleksandr(dot)shulgin(at)zalando(dot)de>, Artur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Oleg Bartunov <obartunov(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, David Steele <david(at)pgmasters(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] [PATCH] Generic type subscripting
Date: 2019-02-01 11:02:28
Message-ID: CA+q6zcUZFYNFRoU2zL+VQSyPx8+oA82ygv3M+Lrksoew_Go1FQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

> On Thu, Jan 31, 2019 at 4:43 PM Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
>
> čt 31. 1. 2019 v 16:39 odesílatel Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> napsal:
>>
>> Would anybody object to me pushing part 0001 soon? It seems pointless
>> to force Dmitry keep rebasing a huge renaming patch all this time. I
>> think the general feeling is that this is a desirable change, so let's
>> keep things moving.
>>
>> That having been said ... while the current 0001 patch does apply
>> semi-cleanly (`git apply -3` does it), it does not compile, probably
>> because of header refactoring. Please rebase and make sure that each
>> individual patch compiles cleanly.
>
> +1

> On Thu, Jan 31, 2019 at 4:45 PM Dmitry Dolgov <9erthalion6(at)gmail(dot)com> wrote:
> Oh, sorry for that, I'll fix it in a moment.

The moment was longer than I expected, but here is the rebased version, where
all the individual patches can be applied and compiled cleanly (although there
is still functional dependency between 0002 and 0003, since the former
introduces a new subscripting without any implementation, and the latter
introduces an implementation for array data type).

Attachment Content-Type Size
0003-Subscripting-for-array-v18.patch application/x-patch 24.8 KB
0001-Renaming-for-new-subscripting-mechanism-v18.patch application/x-patch 82.4 KB
0005-Subscripting-documentation-v18.patch application/x-patch 20.0 KB
0004-Subscripting-for-jsonb-v18.patch application/x-patch 33.6 KB
0002-Base-implementation-of-subscripting-mechanism-v18.patch application/x-patch 47.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Surafel Temesgen 2019-02-01 11:10:38 Re: FETCH FIRST clause PERCENT option
Previous Message Andrew Gierth 2019-02-01 10:46:35 Re: LD_LIBRARY_PATH_RPATH