Re: [HACKERS] [PATCH] Generic type subscripting

From: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
To: David Fetter <david(at)fetter(dot)org>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Oleksandr Shulgin <oleksandr(dot)shulgin(at)zalando(dot)de>, Artur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Oleg Bartunov <obartunov(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, David Steele <david(at)pgmasters(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] [PATCH] Generic type subscripting
Date: 2019-07-11 14:30:46
Message-ID: CA+q6zcUJTtp_GxnX+Q7Zo5RMk+12Tw-rsqLGnh+76hzJ3MH5LA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Thu, Jul 11, 2019 at 9:47 AM David Fetter <david(at)fetter(dot)org> wrote:
>
> Looks great!
>
> The tutorial piece has bit-rotted slightly. Please find attached a
> patch atop yours that fixes it.

Indeed, I've missed this change, thank you! Although there supposed to be an
upperindex, not numupper (since the latter is just a number of upper indexes).

Attachment Content-Type Size
v25-0001-Base-implementation-of-subscripting-mechanism.patch application/octet-stream 48.3 KB
v25-0002-Subscripting-for-array.patch application/octet-stream 24.8 KB
v25-0004-Subscripting-documentation.patch application/octet-stream 20.0 KB
v25-0003-Subscripting-for-jsonb.patch application/octet-stream 33.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2019-07-11 14:33:18 Re: [HACKERS] [PATCH] Generic type subscripting
Previous Message Bruce Momjian 2019-07-11 14:30:30 Re: [HACKERS] [WIP] Effective storage of duplicates in B-tree index.