Re: reset implementation

On Thu, May 17, 2012 at 4:21 PM, Federico Di Gregorio <fog(at)dndg(dot)it> wrote:
> On 17/05/12 17:06, Daniele Varrazzo wrote:
>> Hello
>>
>> psycopg implements the connection.reset() method using the commands
>> RESET ALL and SET SESSION AUTHORIZATION DEFAULT.
>>
>> Reading pgpool2 docs [1], I see that from PG 8.3 "DISCARD ALL" would
>> be more appropriate: it is equivalient to RESET ALL and SET SESSION
>> AUTHORIZATION DEFAULT plus more [2].
>
> What bothers me is that executes the equivalent of:
>
> UNLISTEN *;
>
> IMHO that's correct for connection.reset() but I don't know how many
> people out there are using NOTIFY and .reset() togheter and I don't want
> to break their code.

My assumption is that if somebody calls reset() he doesn't expect the
connection to keep on doing what it was before. But I've already
created more than one issue thinking something wouldn't have had side
effects, while in real world... so I don't want to push too much on
this.

-- Daniele