Re: fdatasync performance problem with large number of DB files

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Paul Guo <guopa(at)vmware(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Brown <michael(dot)brown(at)discourse(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: fdatasync performance problem with large number of DB files
Date: 2021-03-18 10:19:13
Message-ID: CA+hUKGLkoO6i2qoP6u9uKPx8SL4MGzMnT+xQJ+p_x3FggH1Z8A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Mar 18, 2021 at 8:52 PM Paul Guo <guopa(at)vmware(dot)com> wrote:
> About the syncfs patch, my first impression on the guc name sync_after_crash
> is that it is a boolean type. Not sure about other people's feeling. Do you guys think
> It is better to rename it to a clearer name like sync_method_after_crash or others?

Works for me. Here is a new version like that, also including the
documentation change discussed with Fujii-san, and a couple of
cosmetic changes.

Attachment Content-Type Size
v3-0001-Optionally-use-syncfs-for-SyncDataDirectory-on-Li.patch text/x-patch 10.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2021-03-18 10:21:45 Re: hint Consider using pg_file_read()
Previous Message Masahiro Ikeda 2021-03-18 10:16:18 Re: make the stats collector shutdown without writing the statsfiles if the immediate shutdown is requested.