Re: [PATCH] psql: Add tab-complete for optional view parameters

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: vignesh C <vignesh21(at)gmail(dot)com>
Cc: Christoph Heiss <christoph(at)c8h4(dot)io>, Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] psql: Add tab-complete for optional view parameters
Date: 2023-01-11 22:29:11
Message-ID: CA+hUKGLiY1e+1=pB7hXJOyGj1dJOfgde+HmiSnv3gDKayUFJMA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jan 12, 2023 at 5:50 AM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> For some reason CFBot is not able to apply the patch, please have a
> look and post an updated version if required, also check and handle
> Dean Rasheed and Jim Jones comment if applicable:
> === Applying patches on top of PostgreSQL commit ID
> 5f6401f81cb24bd3930e0dc589fc4aa8b5424cdc ===
> === applying patch
> ./v2-0001-psql-Add-tab-complete-for-optional-view-parameter.patch
> gpatch: **** Only garbage was found in the patch input.

Melanie pointed me at this issue. This particular entry is now fixed,
and I think I know what happened: cfbot wasn't checking the HTTP
status when downloading patches from the web archives, because I had
incorrectly assumed Python's requests.get() would raise an exception
if the web server sent an error status, but it turns out you have to
ask for that. I've now fixed that. So I think it was probably trying
to apply one of those "guru meditation" error message the web archives
occasionally spit out.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2023-01-11 22:29:25 Re: pgsql: Delay commit status checks until freezing executes.
Previous Message Peter Eisentraut 2023-01-11 22:10:07 Re: pgsql: Doc: add XML ID attributes to <sectN> and <varlistentry> tags.