Re: "WIP: Data at rest encryption" patch and, PostgreSQL 11-beta3

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Antonin Houska <ah(at)cybertec(dot)at>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Toshi Harada <harada(dot)toshi(at)po(dot)ntt-tx(dot)co(dot)jp>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: "WIP: Data at rest encryption" patch and, PostgreSQL 11-beta3
Date: 2019-07-08 01:07:29
Message-ID: CA+hUKGLJtoBzjpAXL+Go4VnRSPeFWsmaD1AaMnFmj=t=rM3r7Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jul 6, 2019 at 2:42 AM Antonin Houska <ah(at)cybertec(dot)at> wrote:
> I've reworked the way key is passed to postmaster (v04-0003-...) so it's
> easier to call the encryption key command interactively, adjusted pg_upgrade
> so that it preserves database, tablespace and relfilenode OIDs (v04-0014-...),
> reorganized the code a bit and split the code into more diffs.

Hi Antonin,

Some robotic feedback:

1. On Linux, an assertion failed:

ExceptionalCondition (conditionName=conditionName(at)entry=0x973891
"!(decrypt_p == p)", errorType=errorType(at)entry=0x928d7d
"FailedAssertion", fileName=fileName(at)entry=0x973827 "xlogutils.c",
lineNumber=lineNumber(at)entry=815) at assert.c:54

See full stack here:
https://travis-ci.org/postgresql-cfbot/postgresql/builds/555550833

2. On Windows the build failed:

https://ci.appveyor.com/project/postgresql-cfbot/postgresql/build/1.0.46469

--
Thomas Munro
https://enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2019-07-08 01:18:21 Re: Optimze usage of immutable functions as relation
Previous Message Thomas Munro 2019-07-08 00:59:26 Re: Duplicated LSN in ReorderBuffer