| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
| Cc: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: Streaming I/O, vectored I/O (WIP) |
| Date: | 2024-03-24 23:02:46 |
| Message-ID: | CA+hUKGL-ONQnnnp-SONCFfLJzqcpAheuzZ+-yTrD9WBM-GmAcg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 25, 2024 at 6:30 AM Melanie Plageman
<melanieplageman(at)gmail(dot)com> wrote:
> I haven't reviewed the whole patch, but as I was rebasing
> bitmapheapscan streaming read user, I found callback_private confusing
> because it seems like it is a private callback, not private data
> belonging to the callback. Perhaps call it callback_private_data? Also
WFM.
> maybe mention what it is for in the comment above
> streaming_read_buffer_begin() and in the StreamingRead structure
> itself.
Yeah. I've tried to improve the comments on all three public
functions. I also moved the three public functions _begin(), _next(),
_end() to be next to each other after the static helper functions.
Working on perf regression/tuning reports today, more soon...
| Attachment | Content-Type | Size |
|---|---|---|
| v9-0001-Provide-vectored-variant-of-ReadBuffer.patch | text/x-patch | 37.5 KB |
| v9-0002-Provide-API-for-streaming-reads-of-relations.patch | text/x-patch | 29.3 KB |
| v9-0003-Use-streaming-reads-in-pg_prewarm.patch | text/x-patch | 2.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2024-03-24 23:41:20 | Re: Built-in CTYPE provider |
| Previous Message | Melanie Plageman | 2024-03-24 22:37:20 | Re: BitmapHeapScan streaming read user and prelim refactoring |