| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Fabien Coelho <postgresql(dot)org(at)coelho(dot)net> |
| Subject: | Re: pgbench - add minimal stats on initialization |
| Date: | 2019-07-15 23:43:32 |
| Message-ID: | CA+hUKGKewEwbzS5k6ugDb86rRVdWO_ih_KFN+OZfiy4B0=Zaqg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Apr 12, 2019 at 12:44 AM Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com> wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world: tested, passed
> Implements feature: tested, passed
> Spec compliant: tested, passed
> Documentation: not tested
>
> Patch works fine on my machine.
>
> The new status of this patch is: Ready for Committer
I spotted one typo, a comma where a semi-colon was wanted:
+ op = "generate",
initGenerateData(con);
break;
I fixed that, ran it through pgindent and committed. Thanks for the
patch and review!
--
Thomas Munro
https://enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2019-07-15 23:44:09 | Re: refactoring - share str2*int64 functions |
| Previous Message | Alvaro Herrera | 2019-07-15 23:39:20 | Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS) |