From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
---|---|
To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
Cc: | Tristan Partin <tristan(at)neon(dot)tech>, Noah Misch <noah(at)leadboat(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: check_strxfrm_bug() |
Date: | 2023-07-07 20:30:31 |
Message-ID: | CA+hUKGKetP-OqhZ7k+3+Ug2SFMbejtpXhxJs7GgNtPev9=mVTw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Jul 7, 2023 at 4:20 AM Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
> I think the correct solution is to set HAVE_MBSTOWCS_L in Solution.pm.
> Compare HAVE_FSEEKO, which is set in Solution.pm with fseeko being
> defined in win32_port.h.
In this version I have it in there, but set it to undef. This way
configure (MinGW), meson (MinGW or MSVC), and Solution.pm all agree.
This version passes on CI (not quite sure what I screwed up before).
To restate the problem I am solving with this Solution.pm change +
associated changes in the C: configure+MinGW disabled the libc
provider completely before. With this patch that is fixed, and that
forced me to address the inconsistency (because if you have the libc
provider but no _l functions, you hit uselocale() code paths that
Windows can't do). It was a bug, really, but I don't plan to
back-patch anything (nobody really uses configure+MinGW builds AFAIK,
they exist purely as a developer [in]convenience). But that explains
why I needed to make a change.
Thinking about how to bring this all into "normal" form -- where
HAVE_XXX means "system defines XXX", not "system defines XXX || we
define a replacement" -- leads to the attached. Do you like this one?
Attachment | Content-Type | Size |
---|---|---|
v3-0001-All-supported-systems-have-locale_t.patch | text/x-patch | 24.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tristan Partin | 2023-07-07 20:52:36 | Re: check_strxfrm_bug() |
Previous Message | Jeff Davis | 2023-07-07 19:17:20 | Re: 010_database.pl fails on openbsd w/ LC_ALL=LANG=C |