| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Checking pgwin32_is_junction() errors |
| Date: | 2022-08-05 09:17:45 |
| Message-ID: | CA+hUKGKWR3=B_=qg_+bmX=pjtQ5Zk_3Agco7xg8GgpvZBafJ7w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Aug 4, 2022 at 9:42 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> On Thu, Aug 4, 2022 at 9:28 AM Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> > On 2022-08-01 Mo 16:06, Andrew Dunstan wrote:
> > > I'll try it out on fairywren/drongo.
>
> > They are happy with patches 2, 3, and 4.
>
> Thanks for testing!
>
> If there are no objections, I'll go ahead and commit these later today.
Hmm, POSIX says st_link should contain the length of a symlink's
target path, so I suppose we should probably set that even though we
never consult it. Here's a version that does that. I also removed
the rest of the now redundant #ifdef S_ISLNK conditions.
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Added-Windows-with-MinGW-environment-in-Cirrus-CI.patch | text/x-patch | 4.2 KB |
| v4-0002-Provide-lstat-for-Windows.patch | text/x-patch | 5.0 KB |
| v4-0004-Replace-pgwin32_is_junction-with-lstat.patch | text/x-patch | 9.8 KB |
| v4-0003-Make-unlink-work-for-junction-points-on-Windows.patch | text/x-patch | 2.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2022-08-05 09:26:04 | Re: Cleaning up historical portability baggage |
| Previous Message | wangw.fnst@fujitsu.com | 2022-08-05 09:06:49 | RE: Data is copied twice when specifying both child and parent table in publication |