Re: [PATCH] Replica sends an incorrect epoch in its hot standby feedback to the Master

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: "Palamadai, Eka" <ekanatha(at)amazon(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Replica sends an incorrect epoch in its hot standby feedback to the Master
Date: 2020-03-11 06:47:06
Message-ID: CA+hUKGKUHQeZSv9coYP4yUTFyYf3qL-J7GKpnn0up7B+C0jkCg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Feb 22, 2020 at 6:10 AM Palamadai, Eka <ekanatha(at)amazon(dot)com> wrote:
> Thanks a lot for the feedback. Please let me know if you have any further comments. Meanwhile, I have also added this patch to "Commitfest 2020-03" at https://commitfest.postgresql.org/27/2464.

Thanks for the excellent reproducer for this obscure bug. You said
the problem exists in 9.6-11, but I'm also able to reproduce it in
9.5. That's the oldest supported release, but it probably goes back
further. I confirmed that this patch fixes the immediate problem.
I've attached a version of your patch with a commit message, to see if
anyone has more feedback on this.

Attachment Content-Type Size
0001-Fix-nextXid-tracking-bug-on-standbys-9.5-11-only.patch text/x-patch 1.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Craig Ringer 2020-03-11 06:56:46 Re: [PATCH] Skip llvm bytecode generation if LLVM is missing
Previous Message Craig Ringer 2020-03-11 06:41:30 Re: custom postgres launcher for tests