Re: File descriptors in exec'd subprocesses

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: "Gregory Stark (as CFM)" <stark(dot)cfm(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)lists(dot)postgresql(dot)org, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: File descriptors in exec'd subprocesses
Date: 2023-03-02 22:04:21
Message-ID: CA+hUKGKPNFcfBQduqof4-7C=avjcSfdkKBGvQoRuAvfocnvY0A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Mar 2, 2023 at 9:57 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> On Thu, Mar 2, 2023 at 9:49 AM Gregory Stark (as CFM)
> <stark(dot)cfm(at)gmail(dot)com> wrote:
> > On Mon, 20 Feb 2023 at 23:04, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> > > Done like that in this version. This is the version I'm thinking of
> > > committing, unless someone wants to argue for another level.
> >
> > FWIW the cfbot doesn't understand this patch series. I'm not sure why
> > but it's only trying to apply the first (the MacOS one) and it's
> > failing to apply even that.
>
> Ah, it's because I committed one patch in the series. I'll commit one
> more, and then repost the rest, shortly.

I pushed the main patch, "Don't leak descriptors into subprograms.".
Here's a rebase of the POSIX-next stuff, but I'll sit on these for a
bit longer to see if the build farm agrees with my claim about the
ubiquity of O_CLOEXEC, and if anyone has comments on this stuff.

Attachment Content-Type Size
v5-0001-Use-accept4-to-accept-connections-where-available.patch text/x-patch 5.6 KB
v5-0002-Use-newer-client-socket-options-where-available.patch text/x-patch 2.9 KB
v5-0003-Use-pipe2-for-postmaster-pipe-where-available.patch text/x-patch 4.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2023-03-02 22:06:04 Re: buildfarm + meson
Previous Message Andrew Dunstan 2023-03-02 22:00:47 Re: buildfarm + meson