| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Жарков Роман <r(dot)zharkov(at)postgrespro(dot)ru> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Checking pgwin32_is_junction() errors |
| Date: | 2022-08-08 22:44:55 |
| Message-ID: | CA+hUKGJtJaKCuuEskzRkcGMjRYnf1aLQmEkzf=o-ZM=7fqNkow@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 9, 2022 at 8:30 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> On Mon, Aug 8, 2022 at 8:23 PM <r(dot)zharkov(at)postgrespro(dot)ru> wrote:
> > "C:/HOME" is the junction point to the second volume on my hard drive -
> > "\??\Volume{GUID}\" which name pgreadlink() erroneously strips here:
> > https://github.com/postgres/postgres/blob/7e29a79a46d30dc236d097825ab849158929d977/src/port/dirmod.c#L357.
> ... Would it
> be better to say: if it doesn't begin with "\??\X:", where X could be
> any letter, then don't modify it?
Concretely, I wonder if this is a good fix at least in the short term.
Does this work for you, and do the logic and explanation make sense?
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-readlink-for-more-complex-Windows-paths.patch | text/x-patch | 2.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2022-08-08 23:07:16 | Re: optimize lookups in snapshot [sub]xip arrays |
| Previous Message | Nathan Bossart | 2022-08-08 22:32:54 | Re: optimize lookups in snapshot [sub]xip arrays |