| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Tristan Partin <tristan(at)neon(dot)tech>, Noah Misch <noah(at)leadboat(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: check_strxfrm_bug() |
| Date: | 2023-07-10 21:54:23 |
| Message-ID: | CA+hUKGJ=+rE2f2CKqcFLqEDvc9mB-LxNDsbyZoBNcusTeTW=Ew@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jul 11, 2023 at 2:28 AM Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
> This looks sensible to me.
>
> If we ever need mbstowcs_l() etc. outside of pg_locale.c, then the
> proper way would be to make a mbstowcs_l.c file in src/port/.
>
> But I like your approach for now because it moves us more firmly into
> the direction of having it contained in pg_locale.c, instead of having
> some knowledge global and some local.
Thanks. Pushed.
That leaves only one further cleanup opportunity from discussion this
thread, for future work: a TRUST_STRXFRM-ectomy.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2023-07-10 22:35:43 | Re: Generating code for query jumbling through gen_node_support.pl |
| Previous Message | Nikolay Samokhvalov | 2023-07-10 21:37:24 | Re: pg_upgrade instructions involving "rsync --size-only" might lead to standby corruption? |