| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Ashwin Agrawal <aagrawal(at)pivotal(dot)io> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Kevin Grittner <kgrittn(at)gmail(dot)com> |
| Subject: | Re: An out-of-date comment in nodeIndexonlyscan.c |
| Date: | 2021-06-12 02:35:07 |
| Message-ID: | CA+hUKGJ0woC8m8c9eZzTyVUQi+8D8Pibjo7XVTu83kf8SfQqLg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jun 28, 2019 at 12:55 PM Ashwin Agrawal <aagrawal(at)pivotal(dot)io> wrote:
> On Thu, Jun 27, 2019 at 4:33 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
>>
>> Here's a patch I'd like to commit to fix the comment. We could look
>> at improving the actual code after
>> https://commitfest.postgresql.org/23/2169/ is done.
>
> Change looks good to me.
... and here is the corresponding code change, with a test to
demonstrate the change.
I'm working on a proof-of-concept to skip the btree page lock
sometimes too, which seems promising, but it requires some planner
work which has temporarily pretzeled my brain.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Use-tuple-level-SIREAD-locks-for-index-only-scans.patch | text/x-patch | 6.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2021-06-12 02:36:19 | Re: [PATCH] Fix buffer not null terminated on (ecpg lib) |
| Previous Message | Justin Pryzby | 2021-06-12 02:33:25 | pg_filenode_relation(0,0) elog |