| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Marina Polyakova <m(dot)polyakova(at)postgrespro(dot)ru>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, kuroda(dot)hayato(at)fujitsu(dot)com, David Rowley <dgrowleyml(at)gmail(dot)com> |
| Subject: | Re: pgbench: option delaying queries till connections establishment? |
| Date: | 2021-03-13 03:37:11 |
| Message-ID: | CA+hUKG+w_5ScE0Q-_9BGR8hFd486nZegn5y-6p-PzzYiHTc1Rw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Mar 13, 2021 at 4:09 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> OK, cool. I don't think it's hard, just do
>
> if test "$enable_thread_safety" = yes; then
> AC_REPLACE_FUNCS(pthread_barrier_wait)
> fi
>
> Probably this check should be likewise conditional:
>
> AC_SEARCH_LIBS(pthread_barrier_wait, pthread)
Thanks. This seems to work for me on a Mac. I confirmed with nm that
we don't define or reference any pthread_XXX symbols with
--disable-thread-safety, and we do otherwise, and the pgbench tests
pass either way.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-new-pthread-code-to-respect-disable-thread-safet.patch | application/octet-stream | 6.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-03-13 03:58:56 | Re: pgbench: option delaying queries till connections establishment? |
| Previous Message | Kazutaka Onishi | 2021-03-13 03:35:46 | Re: TRUNCATE on foreign table |