| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Erik Rijkers <er(at)xs4all(dot)nl>, Michael Paquier <michael(at)paquier(dot)xyz>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Darafei Komяpa Praliaskouski <me(at)komzpa(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Yet another fast GiST build (typo) |
| Date: | 2020-07-30 01:26:42 |
| Message-ID: | CA+hUKG+UoDyKgvO9BLE7543D1Yu8qQoBHAZRDSo_ETowja6GHw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 10, 2020 at 6:55 PM Andrey M. Borodin <x4mmm(at)yandex-team(dot)ru> wrote:
> Thanks! Fixed.
It's not a bug, but I think those 64 bit constants should be wrapped
in UINT64CONST(), following our convention.
I'm confused about these two patches: 0001 introduces
gist_point_fastcmp(), but then 0002 changes it to gist_bbox_fastcmp().
Maybe you intended to keep both of them? Also 0002 seems to have
fixups for 0001 squashed into it.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2020-07-30 01:28:40 | Re: Ought to use heap_multi_insert() for pg_attribute/depend insertions? |
| Previous Message | Peter Geoghegan | 2020-07-30 00:40:08 | Re: Default setting for enable_hashagg_disk |