| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_tablespace_location() failure with allow_in_place_tablespaces |
| Date: | 2022-03-15 02:55:56 |
| Message-ID: | CA+hUKG+LyP3paszHv-a2FCH_fOPgO+eLtahwwrCD0fgkfPqMVA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 15, 2022 at 2:50 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Tue, Mar 15, 2022 at 02:33:17PM +1300, Thomas Munro wrote:
> > As for the complaint about pg_tablespace_location() failing, would it
> > be better to return an empty string? That's what was passed in as
> > LOCATION. Something like the attached.
>
> Hmm, I don't think so. The point of the function is to be able to
> know the location of a tablespace at SQL level so as we don't have any
> need to hardcode its location within any external tests (be it a
> pg_regress test or a TAP test) based on how in-place tablespace paths
> are built in the backend, so I think that we'd better report either a
> relative path from data_directory or an absolute path, but not an
> empty string.
>
> In any case, I'd suggest to add a regression test. What I have sent
> upthread would be portable enough.
Fair enough. No objections here.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2022-03-15 04:04:16 | Re: Issue with pg_stat_subscription_stats |
| Previous Message | Masahiko Sawada | 2022-03-15 02:51:50 | Re: Skipping logical replication transactions on subscriber side |