Re: Cleaning up historical portability baggage

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Cleaning up historical portability baggage
Date: 2022-08-11 10:02:29
Message-ID: CA+hUKG+L_3brvh=8e0BW_VfX9h7MtwgN=nFHP5o7X2oZucY9dg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Here's a new batch of these:

Remove configure probe for sys/uio.h.
Remove configure probes for sys/un.h and struct sockaddr_un.
Remove configure probe for sys/select.h.
Remove configure probes for sys/ipc.h, sys/sem.h, sys/shm.h.
Remove configure probe for sys/resource.h and refactor.
Remove configure probe for shl_load library.

The most interesting things to say about these ones are:
* The concept of a no-Unix-socket build is removed. We should be
able to do that now, right? Peter E seemed to say approximately that
in the commit message for 797129e5. Or is there a thought that a new
operating system might show up that doesn't have 'em and we'd wish
we'd kept this stuff well marked out?
* Instead of eg HAVE_SYS_RESOURCE_H I supplied <sys/resource.h> and
moved the relevant declarations there from the big random-win2-stuff
header, and likewise for <sys/un.h>

(I still plan to get rid of no-threads-builds soon, but I got stuck
figuring out how to make sure I don't break the recent magic ldap
library detection... more soon.)

Attachment Content-Type Size
0001-Remove-configure-probe-for-sys-uio.h.patch application/octet-stream 4.2 KB
0002-Remove-configure-probes-for-sys-un.h-and-struct-sock.patch application/octet-stream 23.7 KB
0003-Remove-configure-probe-for-sys-select.h.patch application/octet-stream 10.7 KB
0004-Remove-configure-probes-for-sys-ipc.h-sys-sem.h-sys-.patch application/octet-stream 6.0 KB
0005-Remove-configure-probe-for-sys-resource.h-and-refact.patch application/octet-stream 12.5 KB
0006-Remove-configure-probe-for-shl_load-library.patch application/octet-stream 2.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2022-08-11 10:10:35 Re: designated initializers
Previous Message Matthias van de Meent 2022-08-11 08:47:54 Re: Remaining case where reltuples can become distorted across multiple VACUUM operations