Re: pgsql: Reset ALTER TABLE lock levels to AccessExclusiveLock in all case

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Reset ALTER TABLE lock levels to AccessExclusiveLock in all case
Date: 2011-07-05 15:00:25
Message-ID: CA+U5nMJU7vSJktb8=TR_TcSvAEPU4Ek=kG4Dz=Hq1UW19Ag83Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Tue, Jul 5, 2011 at 2:46 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Mon, Jul 4, 2011 at 6:14 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>> On Mon, Jul 4, 2011 at 9:31 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>>> Reset ALTER TABLE lock levels to AccessExclusiveLock in all cases.
>>> Locks on inheritance parent remain at lower level, as they were before.
>>> Remove entry from 9.1 release notes.
>>
>> This commit caused pgbuildfarm failures on 15 machines this morning.
>> Later commit fixes this, I forgot that the lock level is specifically
>> mentioned in regression test results.
>
> I believe you need a similar fix in CreateTrigger() and DefineQueryRewrite().

Thanks. Will address.

--
 Simon Riggs                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2011-07-05 15:03:44 Re: [COMMITTERS] pgsql: Move Trigger and TriggerDesc structs out of rel.h into a new rel
Previous Message Tom Lane 2011-07-05 14:47:03 Re: pgsql: Move Trigger and TriggerDesc structs out of rel.h into a new rel