Re: [BUGS] BUG #12989: pg_size_pretty with negative values

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Adrian Vondendriesch <adrian(dot)vondendriesch(at)credativ(dot)de>
Cc: Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com>, "pgsql-bugs(at)postgresql(dot)org" <pgsql-bugs(at)postgresql(dot)org>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Christian Almeida <cbalmeida(at)gmail(dot)com>
Subject: Re: [BUGS] BUG #12989: pg_size_pretty with negative values
Date: 2015-11-06 17:53:56
Message-ID: CA+TgmobhzmbvxghvDUvS_7-7+EYjLeXuH1_8kjyMBQxsLB1pRA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Fri, Nov 6, 2015 at 12:44 PM, Adrian Vondendriesch
<adrian(dot)vondendriesch(at)credativ(dot)de> wrote:
> Am 06.11.2015 um 17:06 schrieb Robert Haas:
>> On Thu, Nov 5, 2015 at 4:19 PM, Adrian.Vondendriesch
>> <Adrian(dot)Vondendriesch(at)credativ(dot)de> wrote:
>>> New patch attached and rebased on HEAD
>>> (8c75ad436f75fc629b61f601ba884c8f9313c9af).
>>
>> I've committed this with some modifications:
>>
>> - I changed the comment for the half_rounded() macros because the one
>> you had just restated the code.
>> - I tightened up the coding in numeric_half_rounded() very slightly.
>> - You didn't, as far as I can see, modify the regression test schedule
>> to execute the files you added. I consolidated them into one file,
>> added it to the schedule, and tightened up the SQL a bit.
>
> Looks much better now.
>
>>
>> Thanks for the patch, and please let me know if I muffed anything.
>
> Thanks for reviewing and improving the changes.
>
> I changed the status to committed.

Great, thank you for working on this.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Vijayakumar Krishnan 2015-11-06 20:18:28 Re: BUG #13757: Able to write to postgres even when the main process has been killed
Previous Message Adrian Vondendriesch 2015-11-06 17:44:36 Re: [HACKERS] BUG #12989: pg_size_pretty with negative values

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Wagner 2015-11-06 17:56:31 Re: patch for geqo tweaks
Previous Message Robert Haas 2015-11-06 17:53:18 Re: [PATCH] Refactoring of LWLock tranches