|From:||Robert Haas <robertmhaas(at)gmail(dot)com>|
|To:||Michael Paquier <michael(dot)paquier(at)gmail(dot)com>|
|Cc:||Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>|
|Subject:||Re: Speed up Clog Access by increasing CLOG buffers|
|Views:||Raw Message | Whole Thread | Download mbox|
On Tue, Jan 31, 2017 at 11:35 PM, Michael Paquier
>> Thanks for the review.
> Moved to CF 2017-03, the 8th commit fest of this patch.
I think eight is enough. Committed with some cosmetic changes.
I think the turning point for this somewhat-troubled patch was when we
realized that, while results were somewhat mixed on whether it
improved performance, wait event monitoring showed that it definitely
reduced contention significantly. However, I just realized that in
both this case and in the case of group XID clearing, we weren't
advertising a wait event for the PGSemaphoreLock calls that are part
of the group locking machinery. I think we should fix that, because a
quick test shows that can happen fairly often -- not, I think, as
often as we would have seen LWLock waits without these patches, but
often enough that you'll want to know. Patch attached.
The Enterprise PostgreSQL Company
|Next Message||Tels||2017-03-09 23:13:17||Re: [PATCH]: fix bug in SP-GiST box_ops|
|Previous Message||Kevin Grittner||2017-03-09 22:48:12||Re: delta relations in AFTER triggers|