| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Cc: | Craig Ringer <craig(at)2ndquadrant(dot)com>, Asim Praveen <apraveen(at)pivotal(dot)io>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: Postgres, fsync, and OSs (specifically linux) |
| Date: | 2018-11-08 20:06:40 |
| Message-ID: | CA+TgmobfSmKXEgJmf6qxLXygFLV1C5C5Ao_xJGpznkAX4TGWLA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 8, 2018 at 3:04 PM Thomas Munro
<thomas(dot)munro(at)enterprisedb(dot)com> wrote:
> My reasoning for choosing bms_join() is that it cannot fail, assuming
> the heap is not corrupted. It simply ORs the two bit-strings into
> whichever is the longer input string, and frees the shorter input
> string. (In an earlier version I used bms_union(), this function's
> non-destructive sibling, but then realised that it could fail to
> allocate() causing us to lose track of a 1 bit).
Oh, OK. I was assuming it was allocating.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2018-11-08 20:59:36 | Re: ATTACH/DETACH PARTITION CONCURRENTLY |
| Previous Message | Thomas Munro | 2018-11-08 20:03:47 | Re: Postgres, fsync, and OSs (specifically linux) |