Re: pgsql: Reset ALTER TABLE lock levels to AccessExclusiveLock in all case

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Reset ALTER TABLE lock levels to AccessExclusiveLock in all case
Date: 2011-07-05 13:46:20
Message-ID: CA+Tgmob3J+d5NFq+_LJGuteV31Ym63fULMde=pffpg3xaaX6tQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Mon, Jul 4, 2011 at 6:14 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> On Mon, Jul 4, 2011 at 9:31 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>> Reset ALTER TABLE lock levels to AccessExclusiveLock in all cases.
>> Locks on inheritance parent remain at lower level, as they were before.
>> Remove entry from 9.1 release notes.
>
> This commit caused pgbuildfarm failures on 15 machines this morning.
> Later commit fixes this, I forgot that the lock level is specifically
> mentioned in regression test results.

I believe you need a similar fix in CreateTrigger() and DefineQueryRewrite().

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2011-07-05 14:47:03 Re: pgsql: Move Trigger and TriggerDesc structs out of rel.h into a new rel
Previous Message Magnus Hagander 2011-07-05 07:48:11 pgsql: Fix typo in sslmode documentation