| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Kouhei Kaigai <kaigai(at)ak(dot)jp(dot)nec(dot)com> |
| Cc: | Shigeru HANADA <shigeru(dot)hanada(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Thom Brown <thom(at)linux(dot)com>, "pgsql-hackers(at)postgreSQL(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Custom/Foreign-Join-APIs (Re: [v9.5] Custom Plan API) |
| Date: | 2015-04-22 16:21:39 |
| Message-ID: | CA+Tgmob+mz7HhkhfrPdsM80_iUVSHv=QRmehNXjeusgnJXMzSg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Apr 21, 2015 at 10:33 PM, Kouhei Kaigai <kaigai(at)ak(dot)jp(dot)nec(dot)com> wrote:
> [ new patch ]
A little more nitpicking:
ExecInitForeignScan() and ExecInitCustomScan() could declare
currentRelation inside the if (scanrelid > 0) block instead of in the
outer scope.
I'm not too excited about the addition of GetFdwHandlerForRelation,
which is a one-line function used in one place. It seems like we
don't really need that.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2015-04-22 16:23:26 | Re: pgsql: RLS fixes, new hooks, and new test module |
| Previous Message | Andrew Dunstan | 2015-04-22 16:20:06 | Re: Allow SQL/plpgsql functions to accept record |