| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: tableam vs. TOAST |
| Date: | 2019-07-08 16:52:05 |
| Message-ID: | CA+TgmoahReAHd1Kja6hM8Jk7=bApRrMSNBVibAsqMhBnf_9S5Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Jul 7, 2019 at 11:08 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> Thus spake GCC:
>
> detoast.c: In function ‘toast_fetch_datum’:
> detoast.c:308:12: error: variable ‘toasttupDesc’ set but not used
> [-Werror=unused-but-set-variable]
> TupleDesc toasttupDesc;
> ^
Hmm, fixed, I hope.
Here's an updated patch set. In addition to the above fix, I fixed
things up for the new pgindent rules and added a fourth patch that
renames the detoasting functions to something that doesn't include
'heap.'
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| 0004-Rename-attribute-detoasting-functions.patch | application/octet-stream | 13.3 KB |
| 0003-Allow-TOAST-tables-to-be-implemented-using-table-AMs.patch | application/octet-stream | 36.5 KB |
| 0002-Create-an-API-for-inserting-and-deleting-rows-in-TOA.patch | application/octet-stream | 30.5 KB |
| 0001-Split-tuptoaster.c-into-three-separate-files.patch | application/octet-stream | 163.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2019-07-08 17:18:10 | Re: Broken defenses against dropping a partitioning column |
| Previous Message | Ashwin Agrawal | 2019-07-08 16:51:34 | Re: Comment typo in tableam.h |