| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Amul Sul <sulamul(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [Patch] ALTER SYSTEM READ ONLY |
| Date: | 2021-01-18 18:02:39 |
| Message-ID: | CA+TgmoaCN2Sa8Y6DG1MoGyspac2p0eZtNe6zj6rJFKwkaL8EFQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jan 14, 2021 at 6:29 AM Amul Sul <sulamul(at)gmail(dot)com> wrote:
> To move development, testing, and the review forward, I have commented out the
> code acquiring CheckpointLock from CreateCheckPoint() in the 0003 patch and
> added the changes for the checkpointer so that system read-write state change
> request can be processed as soon as possible, as suggested by Robert[1].
>
> I have started a new thread[2] to understand the need for the CheckpointLock in
> CreateCheckPoint() function. Until then we can continue work on this feature by
> skipping CheckpointLock in CreateCheckPoint(), and therefore the 0003 patch is
> marked WIP.
Based on the favorable review comment from Andres upthread and also
your feedback, I committed 0001.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhihong Yu | 2021-01-18 18:08:32 | Re: search_plan_tree(): handling of non-leaf CustomScanState nodes causes segfault |
| Previous Message | Robert Haas | 2021-01-18 18:00:55 | Re: [PATCH] ProcessInterrupts_hook |