| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
| Cc: | Roma Sokolov <sokolov(dot)r(dot)v(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Женя Зайцев <zevlg(at)yandex(dot)ru> |
| Subject: | Re: [PATCH] fix DROP OPERATOR to reset links to itself on commutator and negator |
| Date: | 2016-03-23 15:58:14 |
| Message-ID: | CA+TgmoaA7FhgWDZ6Nu42iLhSFuso2dxUPA3x6rd+0EniS42JYg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 22, 2016 at 9:25 PM, Tomas Vondra
<tomas(dot)vondra(at)2ndquadrant(dot)com> wrote:
> OK, the new code seems more comprehensible to me.
I did not find this version very clear. It wasn't consistent about
using ObjectIdGetDatum() where needed, but the bigger problem was that
I found the logic unnecessarily convoluted. I rewrote it - I believe
more straightforwardly - as attached. How does this look?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| fix_drop_operator_reset_oprcom_and_oprnegate_fields_v5.patch | text/x-diff | 15.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aleksander Alekseev | 2016-03-23 16:00:16 | Re: Patch: fix lock contention for HASHHDR.mutex |
| Previous Message | Jim Nasby | 2016-03-23 15:57:58 | Re: Relax requirement for INTO with SELECT in pl/pgsql |