Re: tablespace_map code cleanup

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: tablespace_map code cleanup
Date: 2020-05-06 15:15:57
Message-ID: CA+Tgmoa8J9UutQpzKdAaQgOKNbxy3jB7bmWDsZOdYHMpntVRhg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, May 4, 2020 at 5:24 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> If we want to move the calculation of size for tablespaces in the
> caller then I think we also need to do something about the progress
> reporting related to phase
> PROGRESS_BASEBACKUP_PHASE_ESTIMATE_BACKUP_SIZE.

Oh, good point. v2 attached.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment Content-Type Size
v2-0001-Don-t-export-basebackup.c-s-sendTablespace.patch application/octet-stream 6.8 KB
v2-0002-Minor-code-cleanup-for-perform_base_backup.patch application/octet-stream 1.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2020-05-06 17:02:26 Re: DROP OWNED CASCADE vs Temp tables
Previous Message Amit Langote 2020-05-06 15:06:33 Re: PG 13 release notes, first draft