From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: WIP patch for parameterized inner paths |
Date: | 2012-01-26 19:48:54 |
Message-ID: | CA+TgmoZoRxfWQYU8YxG80zwMwDVc9JkRCL7O4ph0KEJjyFWh1A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Jan 26, 2012 at 2:27 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>>>> Is there a guard in here against joining a parameterized path to an
>>>> intermediate relation when no SJ is involved? In other words, if
>>>> we're joining a parameterized path on A to a path on B, then either
>>>> the join to B should satisfy at least part of the parameterization
>>>> needed by A, or there should be a special join with A and B on one
>>>> side and a relation that satisfies at least part of the
>>>> parameterization of A on the other.
>
> I've implemented this idea, recast a bit to prevent generating a
> parameterized join path in the first place unless it depends on a
> parameter from a relation for which there's a join ordering constraint
> still outstanding. It seems to get us to where the planning time
> penalty is only about 10%, which frankly is probably less than sampling
> error considering the small set of test cases I'm looking at.
Awesome. If you can post the updated patch, I'll poke at it a little
more and see if anything jumps out at me, but that sounds promising.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2012-01-26 20:06:38 | Re: WIP patch for parameterized inner paths |
Previous Message | Robert Haas | 2012-01-26 19:45:58 | Re: Progress on fast path sorting, btree index creation time |