Re: Event Triggers reduced, v1

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Event Triggers reduced, v1
Date: 2012-07-02 17:57:03
Message-ID: CA+TgmoZkYaUZbEibK23QM0Xp2RNvO5RnyrEJ60CEE201spAJjg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jul 2, 2012 at 1:56 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Fri, Jun 29, 2012 at 5:38 PM, Dimitri Fontaine
> <dimitri(at)2ndquadrant(dot)fr> wrote:
>> Will do a whole warning check pass later. Can you give me your local
>> Makefile trick to turn them into hard errors again please? :)
>
> echo COPT=-Werror > src/Makefile.custom
>
> Your latest patch contains a warning about using a variable
> uninitialized that seems to indicate that you didn't test this very
> carefully: in get_event_triggers, current_any_name is set but not
> used.

Make that used but not set. Anyhow, it's broken. :-(

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2012-07-02 18:17:16 Re: [ADMIN] pg_basebackup blocking all queries with horrible performance
Previous Message Robert Haas 2012-07-02 17:56:36 Re: Event Triggers reduced, v1