| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: subscription worker signalling wal writer too much |
| Date: | 2017-10-05 13:59:53 |
| Message-ID: | CA+TgmoZhw_nyrxYUqSuDh-XEJya-YzfwShki5NuDS=UfgvodrA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 19, 2017 at 8:48 AM, Kyotaro HORIGUCHI
<horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> Though a bit uneasy to have similar code on both side
> (XLogBackgroundFlush and XLogSetAsyncXactLSN) but +1 to this from
> me.
This patch wasn't formatted very nicely; attached is a version that
pgindent likes better and doesn't bust past 80 columns.
I think this patch needs significantly better comments. There's no
explanation of the rather complex formula the patch proposed to use.
Maybe it's just copied from someplace else that does have a comment,
but in that case, the comments here should mention that. And the
comment in the other place should probably be updated too, like:
/* Make sure to keep this in sync with the similar logic in
XLogDoAwesomeStuff() */
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| change_walwriter_wakeup_v3.patch | application/octet-stream | 833 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2017-10-05 14:08:39 | Re: Binary search in fmgr_isbuiltin() is a bottleneck. |
| Previous Message | Robert Haas | 2017-10-05 13:49:46 | Re: Partition-wise join for join between (declaratively) partitioned tables |