| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Richard Guo <guofenglinux(at)gmail(dot)com> |
| Cc: | David Rowley <dgrowleyml(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tender Wang <tndrwang(at)gmail(dot)com>, Paul George <p(dot)a(dot)george19(at)gmail(dot)com>, Andy Fan <zhihuifan1213(at)163(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Matheus Alcantara <matheusssilv97(at)gmail(dot)com> |
| Subject: | Re: Eager aggregation, take 3 |
| Date: | 2025-10-08 14:45:12 |
| Message-ID: | CA+TgmoZ0KR2_XCWHy17=HHcQ3p2Mamc9c6Dnnhf1J6wPYFD9ng@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Oct 7, 2025 at 6:57 AM Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> > 10. I don't think this comment quite makes sense:
> >
> > * "apply_at" tracks the lowest join level at which partial aggregation is
> > * applied.
> >
> > maybe "minimum set of rels to join before partial aggregation can be applied"?
> I've updated the comment for apply_at to clarify that it refers to the
> relids at which partial aggregation is applied.
>
> I've also updated the comments within RelAggInfo to use one-line
> style.
>
> I retained the name of this field though.
For what it's worth, I also don't like that field name. I'm not sure
what to propose instead, but I don't think apply_at is very clear.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joel Jacobson | 2025-10-08 14:53:33 | Re: Optimize LISTEN/NOTIFY |
| Previous Message | Robert Haas | 2025-10-08 14:39:14 | Re: Thoughts on a "global" client configuration? |