From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Noah Misch <noah(at)leadboat(dot)com> |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: psql omits row count under "\x auto" |
Date: | 2012-05-01 21:26:37 |
Message-ID: | CA+TgmoYxeeOQMFg6e6Q1pByoehqb8PkzXrTjwY7wmtCSy0eNGA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Apr 27, 2012 at 3:05 PM, Noah Misch <noah(at)leadboat(dot)com> wrote:
> On Thu, Apr 26, 2012 at 09:25:25PM +0300, Peter Eisentraut wrote:
>> On m??n, 2012-04-23 at 12:30 -0400, Noah Misch wrote:
>> > I've been enjoying "\x auto" in .psqlrc, but I noticed the row count footer
>> > missing when it chooses ordinary output:
>>
>> > Looks like the logic in printQuery() needs further treatment.
>>
>> Hmm, this looks a bit tricky, because at the time we add the footer we
>> don't yet know which output format will be used. I don't have a good
>> idea how to fix that at the moment.
>
> I fiddled with this and settled on moving the default_footer boolean setting
> and the interpretation thereof down from the printQuery() level to the
> printTable() level. That permits delaying the decision until we determine
> whether the final output format is indeed vertical.
Committed.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Hannu Krosing | 2012-05-01 21:29:12 | Re: JSON in 9.2 - Could we have just one to_json() function instead of two separate versions ? |
Previous Message | David Johnston | 2012-05-01 21:20:15 | Re: proposal: additional error fields |