fix tablespace handling in pg_combinebackup

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: fix tablespace handling in pg_combinebackup
Date: 2024-04-17 20:16:55
Message-ID: CA+TgmoYdXTjo9iQeoipTccDpWZzvBNS6EndY2uARM+T4yG_yDg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

In the "Differential code coverage between 16 and HEAD" thread, Andres
pointed out that there wasn't test case coverage for
pg_combinebackup's code to handle files in tablespaces. I looked at
adding that, and as nobody could possibly have predicted, found a bug.

Here's a 2-patch series to (1) enhance
PostgreSQL::Test::Utils::init_from_backup to handle tablespaces and
then (2) fix the bug in pg_combinebackup and add test coverage using
the facilities from the first patch.

--
Robert Haas
EDB: http://www.enterprisedb.com

Attachment Content-Type Size
0001-Make-PostgreSQL-Test-Cluster-init_from_backup-handle.patch application/octet-stream 6.4 KB
0002-pg_combinebackup-Fix-incorrect-tablespace-handling.patch application/octet-stream 6.5 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2024-04-17 21:39:53 plenty code is confused about function level static
Previous Message Andres Freund 2024-04-17 19:41:59 Re: Removing GlobalVisTestNonRemovableHorizon