Re: tableam vs. TOAST

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Prabhat Sahu <prabhat(dot)sahu(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: tableam vs. TOAST
Date: 2019-09-05 17:42:40
Message-ID: CA+TgmoYN8ZmjCUnkAFTag1P7tW=YwSk2sfqqo0mwM6VoTEzzrw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Sep 5, 2019 at 10:52 AM Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> I agree, and can we move forward with this 0001? The idea here is to
> change no code (as also suggested by Tom elsewhere), and it's the
> largest patch in this series by a mile. I checked --color-moved=zebra
> and I think the patch looks fine, and also it compiles fine. I ran
> src/tools/pginclude/headerscheck on it and found no complaints.
>
> So here's a rebased version, where the DETOAST_H whitespace has been
> removed. No other changes from your original. Will you please push
> soon?

Done, thanks. Here's the rest again with the additional rename added
to 0003 (formerly 0004). I think it's probably OK to go ahead with
that stuff, too, but I'll wait a bit to see if anyone wants to raise
more objections.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment Content-Type Size
v5-0003-Rename-some-toasting-functions-based-on-whether-t.patch application/octet-stream 17.0 KB
v5-0002-Allow-TOAST-tables-to-be-implemented-using-table-.patch application/octet-stream 36.9 KB
v5-0001-Create-an-API-for-inserting-and-deleting-rows-in-.patch application/octet-stream 30.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Paul A Jungwirth 2019-09-05 17:45:55 Re: range_agg
Previous Message Rodrigo Ramírez Norambuena 2019-09-05 17:40:02 Re: [PATCH] Connection time for \conninfo