| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Alexandra Wang <alexandra(dot)wang(dot)oss(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "bruce(at)momjian(dot)us" <bruce(at)momjian(dot)us>, lepihov(at)gmail(dot)com |
| Subject: | Re: plan shape work |
| Date: | 2025-09-02 20:07:17 |
| Message-ID: | CA+TgmoYHdZppjyDWWE-dGWNXPzPqf+MXWUVnkhTMkfzusRX8kA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Aug 28, 2025 at 1:22 PM Alexandra Wang
<alexandra(dot)wang(dot)oss(at)gmail(dot)com> wrote:
> Thanks for the patches!
Thanks for the review. Responding just briefly to avoid quoting too much text:
- I'm glad to hear that you like 0002 and consider it an improvement
independent of what follows.
- I'm glad to hear that you're OK with the current split between 0001 and 0002.
- I would like opinions on those topics from more people.
- I have attempted to fix all of the other mistakes that you pointed
out in the attached v3, which is also rebased.
--
Robert Haas
EDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0003-Assert-that-RTIs-of-joined-rels-are-discoverable-.patch | application/octet-stream | 7.1 KB |
| v3-0001-Keep-track-of-what-RTIs-a-Result-node-is-scanning.patch | application/octet-stream | 64.7 KB |
| v3-0002-Consider-a-Result-node-s-relids-in-ExplainPreScan.patch | application/octet-stream | 8.7 KB |
| v3-0004-Give-subplans-names-that-are-known-while-planning.patch | application/octet-stream | 155.3 KB |
| v3-0005-Store-information-about-range-table-flattening-in.patch | application/octet-stream | 6.6 KB |
| v3-0007-Store-information-about-Append-node-consolidation.patch | application/octet-stream | 26.1 KB |
| v3-0006-Store-information-about-elided-nodes-in-the-final.patch | application/octet-stream | 9.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mikhail Kot | 2025-09-02 20:09:54 | Fix segfault while accessing half-initialized hash table in pgstat_shmem.c |
| Previous Message | Ranier Vilela | 2025-09-02 19:53:10 | Re: Get ride of pqbool artifact (src/interfaces/libpq/libpq-fe.h) |