On Sun, Jan 22, 2012 at 11:04 AM, Julien Tachoires <julmon(at)gmail(dot)com> wrote:
> 2011/12/15 Alvaro Herrera <alvherre(at)commandprompt(dot)com>:
>> Uhm, surely you could compare the original toast tablespace to the heap
>> tablespace, and if they differ, handle appropriately when creating the
>> new toast table? Just pass down the toast tablespace into
>> AlterTableCreateToastTable, instead of having it assume that
>> rel->rd_rel->relnamespace is sufficient. This should be done in all
>> cases where a toast tablespace is created, which shouldn't be more than
>> a handful of them.
> Thank you, that way seems right.
> Now, I distinguish before each creation of a TOAST table with
> AlterTableCreateToastTable() : if it will create a new one or recreate
> an existing one.
> Thus, in create_toast_table() when toastTableSpace is equal to
> InvalidOid, we are able :
> - to fallback to the main table tablespace in case of new TOAST table creation
> - to keep it previous tablespace in case of recreation.
> Here's a new version rebased against HEAD.
To ask more directly the question that's come up a few times upthread,
why do *you* think this is useful? What motivated you to want this
behavior, and/or how do you think it could benefit other PostgreSQL
The Enterprise PostgreSQL Company
In response to
pgsql-hackers by date
|Next:||From: Tom Lane||Date: 2012-01-24 18:18:31|
|Subject: Re: lots of unused variable warnings in assert-free builds |
|Previous:||From: Robert Haas||Date: 2012-01-24 18:08:05|
|Subject: Re: lots of unused variable warnings in assert-free builds|