Re: standby recovery fails (tablespace related) (tentative patch and discussion)

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Paul Guo <paulguo(at)gmail(dot)com>
Cc: Paul Guo <guopa(at)vmware(dot)com>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>, Asim Praveen <pasim(at)vmware(dot)com>, "thomas(dot)munro(at)gmail(dot)com" <thomas(dot)munro(at)gmail(dot)com>, "horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp" <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: standby recovery fails (tablespace related) (tentative patch and discussion)
Date: 2021-08-11 12:59:20
Message-ID: CA+TgmoY6tfOTwka88uh9f5Sa-6JcH1XJZfgXGS5DNF4ZSV1OAA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Aug 11, 2021 at 3:59 AM Paul Guo <paulguo(at)gmail(dot)com> wrote:
> Thanks for reviewing. Let me explain a bit. The patch series includes
> four patches.
>
> 0001 and 0002 are test changes for the fix (0003).
> - 0001 is the test framework change that's needed by 0002.
> - 0002 is the test for the code fix (0003).
> 0003 is the code change and the commit message explains the issue in detail.
> 0004 as said is a small enhancement which is a bit independent of the
> previous patches.
>
> Basically the issue is that without the fix crash recovery might fail
> relevant to tablespace.
> Here is the log after I run the tests in 0001/0002 without the 0003 fix.

I do understand all of this, but I (or whoever might commit this)
needs to also be able to understand specifically what each patch is
doing.

--
Robert Haas
EDB: http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2021-08-11 13:22:45 Re: Postgres perl module namespace
Previous Message Robert Haas 2021-08-11 12:54:18 Re: DROP relation IF EXISTS Docs and Tests - Bug Fix