From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Claudio Freire <klaussfreire(at)gmail(dot)com>, Robert Klemme <shortcutter(at)googlemail(dot)com>, Tatsuo Ishii <ishii(at)postgresql(dot)org>, pgsql-performance(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [HACKERS] pg_dump and thousands of schemas |
Date: | 2012-05-31 15:04:12 |
Message-ID: | CA+TgmoY3J3h8bi00JZf5i2VbfpU39kRfDQfuv9hOH9z7PUx87Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-performance |
On Thu, May 31, 2012 at 10:50 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Thu, May 31, 2012 at 10:31 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> I'm not; Jeff Janes is. But you shouldn't be holding your breath
>>> anyway, since it's 9.3 material at this point.
>
>> I agree we can't back-patch that change, but then I think we ought to
>> consider back-patching some variant of Tatsuo's patch. Maybe it's not
>> reasonable to thunk an arbitrary number of relation names in there on
>> one line, but how about 1000 relations per LOCK statement or so? I
>> guess we'd need to see how much that erodes the benefit, but we've
>> certainly done back-branch rearrangements in pg_dump in the past to
>> fix various kinds of issues, and this is pretty non-invasive.
>
> I am not convinced either that this patch will still be useful after
> Jeff's fix goes in, ...
But people on older branches are not going to GET Jeff's fix.
> or that it provides any meaningful savings when
> you consider a complete pg_dump run. Yeah, it will make the lock
> acquisition phase faster, but that's not a big part of the runtime
> except in very limited scenarios (--schema-only, perhaps).
That is not a borderline scenario, as others have also pointed out.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2012-05-31 15:06:50 | Re: [HACKERS] pg_dump and thousands of schemas |
Previous Message | Claudio Freire | 2012-05-31 15:01:42 | Re: [HACKERS] pg_dump and thousands of schemas |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2012-05-31 15:06:50 | Re: [HACKERS] pg_dump and thousands of schemas |
Previous Message | Claudio Freire | 2012-05-31 15:01:42 | Re: [HACKERS] pg_dump and thousands of schemas |