[PATCH] pg_convert improvement

From: Yurii Rashkovskii <yrashk(at)gmail(dot)com>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: [PATCH] pg_convert improvement
Date: 2023-11-24 14:05:29
Message-ID: CA+RLCQyknBPSWXRBQGOi6aYEcdQ9RpH9Kch4GjoeY8dQ3D+vhw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

I propose a patch that ensures `pg_convert` doesn't allocate and copy data
when no conversion is done. It is an unnecessary overhead, especially when
such conversions are done frequently and for large values.

I've tried measuring the performance impact, and the patched version has a
small but non-zero gain.

The patch builds against `master` and `make check` succeeds.

Happy to hear any feedback!

--
Y.

Attachment Content-Type Size
v1-0001-Don-t-copy-bytea-text-in-convert_from-to-unless-conv.patch application/octet-stream 1.8 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2023-11-24 14:07:23 Re: Adding facility for injection points (or probe points?) for more advanced tests
Previous Message Michael Paquier 2023-11-24 14:01:54 Re: GUC names in messages