| From: | Yurii Rashkovskii <yrashk(at)gmail(dot)com> |
|---|---|
| To: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [PATCH] Extend the length of BackgroundWorker.bgw_library_name |
| Date: | 2023-04-24 17:43:51 |
| Message-ID: | CA+RLCQyTvhgMeGcR-JSQLtz9kRTz8LmXR=Jy_38Rjd3nmCEBRA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
You're absolutely right. Here's v3.
On Mon, Apr 24, 2023 at 6:30 PM Aleksander Alekseev <
aleksander(at)timescale(dot)com> wrote:
> Hi,
>
> > This is a very good catch and a suggestion. I've slightly reworked the
> patch, and I also made this static assertion to have less indirection and,
> therefore, make it easier to understand the premise.
> > Version 2 is attached.
>
> ```
> sizeof((BackgroundWorker *)NULL)->bgw_library_name
> ```
>
> I'm pretty confident something went wrong with the parentheses in v2.
>
>
> --
> Best regards,
> Aleksander Alekseev
>
--
Y.
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Extend-the-length-of-BackgroundWorker.bgw_library_na.patch | application/octet-stream | 4.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Regina Obe | 2023-04-24 18:00:30 | RE: [PATCH] Support % wildcard in extension upgrade filenames |
| Previous Message | Mat Arye | 2023-04-24 17:06:24 | Re: [PATCH] Support % wildcard in extension upgrade filenames |