From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
Cc: | Olly Betts <olly(at)survex(dot)com>, "pgadmin-hackers(at)postgresql(dot)org" <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Compilation on Debian SID |
Date: | 2011-12-04 13:02:45 |
Message-ID: | CA+OCxoxLv9jxVVSet=qTCyWF2UWzA=Ho_mcP3D7tU7iCX47gHA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks!
On Sunday, December 4, 2011, Guillaume Lelarge <guillaume(at)lelarge(dot)info>
wrote:
> On Sun, 2011-12-04 at 10:37 +0100, Guillaume Lelarge wrote:
>> On Mon, 2011-11-28 at 17:40 +0000, Dave Page wrote:
>> > On Sat, Nov 26, 2011 at 11:05 PM, Olly Betts <olly(at)survex(dot)com> wrote:
>> > > On Sat, Nov 26, 2011 at 08:18:31PM +0000, Dave Page wrote:
>> > >>
>> > > This isn't original wx code - a number of projects define equivalent
>> > > macros (and often with the same names, which is where the problems
lie
>> > > when they do it in API headers and you want to use two or more such
>> > > projects at once).
>> > >
>> > > So just find one with a licence that's compatible:
>> >
>> > The irony is that on closer examination we don't actually need the
>> > macro at all, as in a Unicode build of wxWidgets (pgAdmin requires
>> > Unicode support), it gets defined away to nothing. So, the patch ends
>> > up looking like the attached.
>> >
>> > Guillaume, please give it a quick check in case I missed anything.
>> >
>>
>> Trying it now...
>>
>
> Compiles fine on Fedora 16, Debian Sid, Ubuntu 11.04, Windows XP, and
> Mac OS X. So I commited the fix.
>
> Thanks to all who participate in this thread.
>
>
> --
> Guillaume
> http://blog.guillaume.lelarge.info
> http://www.dalibo.com
>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Guillaume Lelarge | 2011-12-04 13:26:30 | pgAdmin III commit: Forgot the CHANGELOG |
Previous Message | Guillaume Lelarge | 2011-12-04 12:45:29 | Re: Compilation on Debian SID |