From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Debugger line numbering is off by one |
Date: | 2012-04-25 11:22:34 |
Message-ID: | CA+OCxowfSryzjNHi8AMdA13gzEwmpBC3YL_58PJLFHCMxaQfag@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Wed, Apr 25, 2012 at 11:24 AM, Heikki Linnakangas
<heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
>
> The hack that was removed skipped an initial newline when counting line
> numbers. The PL/pgSQL debugger has a similar hack, but it didn't get the
> memo that it was removed in the backend, so the green current line marker is
> off by one when connected to a 9.1 server. Attached is a patch to fix that.
Hi
It looks fine, except that the "Paused at line" message in the status
bar is still off by one. I tried using the offset you calculated there
as well, and things started getting really weird (like, starting on
line -15, then after single stepping, going back to being 1 off). I
assume that the offset is being used there before it's actually
calculated, but don't have time to play further right now.
Can you fix it please?
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2012-04-25 15:22:06 | pgAdmin III commit: Silence a GCC warning. |
Previous Message | Heikki Linnakangas | 2012-04-25 10:24:46 | Debugger line numbering is off by one |