Re: Fixed issue "Error Message is displayed when the Package is Clicked"

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Fixed issue "Error Message is displayed when the Package is Clicked"
Date: 2012-03-19 13:59:34
Message-ID: CA+OCxowW2axyGnCbHx6P+C1HcJgNAufQnRHwMX=Y1KoPYp=84w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Thu, Mar 15, 2012 at 2:59 PM, Akshay Joshi
<akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
> Hi Dave
>
> I have fixed one issue "Error Message is displayed when the Package is
> Clicked". I have performed the following on enterprisedb database
>
> create or replace package pkgFoo is
>         procedure foo(
>                 arg1 IN varchar default 'Nothing',
>                 arg2 IN integer default 100
>         );
> end pkgFoo;
>
> create or replace package body pkgFoo is
>         procedure foo(
>                 arg1 IN varchar default 'Nothing',
>                 arg2 IN integer default 100
>         ) is
>         begin
>                 dbms_output.put_line(arg1);
>                 dbms_output.put_line(arg2);
>         end;
> end pkgFoo;
>
> Now click on pkgFoo, we will get the error message.It only happens the first
> time.

I cannot reproduce the error, using GIT Master with PPAS 9.0 on CentOS 5.

> Attached is the patch file, please review it. If it looks good then please
> commit it.

The patch is wrong. The restriction is supposed to be " = 'void'" for
procedures, and " != 'void'" for functions, as it already is.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2012-03-19 14:35:38 Re: Fixed issue "Error Message is displayed when the Package is Clicked"
Previous Message Guillaume Lelarge 2012-03-18 22:31:34 Re: [PATCH] Fix for crash while deleting rows on 64 bit systems