Re: Eliminating SPI from RI triggers - take 2

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: "Gregory Stark (as CFM)" <stark(dot)cfm(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: Eliminating SPI from RI triggers - take 2
Date: 2023-07-10 08:30:33
Message-ID: CA+HiwqHVt+jSSvHagx6Rb7MW+w4vzDdo-_pvYGC1G+DhsJs+yQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jul 10, 2023 at 5:27 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> > On 21 Mar 2023, at 06:03, Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> > On Tue, Mar 21, 2023 at 3:54 AM Gregory Stark (as CFM) <stark(dot)cfm(at)gmail(dot)com> wrote:
> >> On Mon, 17 Oct 2022 at 14:59, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> >>> But I think the bigger problem for this patch set is that the
> >>> design-level feedback from
> >>> https://www.postgresql.org/message-id/CA%2BTgmoaiTNj4DgQy42OT9JmTTP1NWcMV%2Bke0i%3D%2Ba7%3DVgnzqGXw%40mail.gmail.com
> >>> hasn't really been addressed, AFAICS. ri_LookupKeyInPkRelPlanIsValid
> >>> is still trivial in v7, and that still seems wrong to me. And I still
> >>> don't know how we're going to avoid changing the semantics in ways
> >>> that are undesirable, or even knowing precisely what we did change. If
> >>> we don't have answers to those questions, then I suspect that this
> >>> patch set isn't going anywhere.
> >>
> >> Amit, do you plan to work on this patch for this commitfest (and
> >> therefore this release?). And do you think it has a realistic chance
> >> of being ready for commit this month?
> >
> > Unfortunately, I don't think so.
>
> This thread has stalled with the patch not building and/or applying for a
> while, so I am going to mark this Returned with Feebdback.

Agreed, I was about to do so myself.

I'll give this another try later in the cycle.

--
Thanks, Amit Langote
EDB: http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alena Rybakina 2023-07-10 08:38:17 Re: POC, WIP: OR-clause support for indexes
Previous Message Daniel Gustafsson 2023-07-10 08:27:53 Re: Eliminating SPI from RI triggers - take 2