| From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Petr Jelinek <petr(at)2ndquadrant(dot)com>, Rafia Sabih <rafia(dot)pghackers(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: adding partitioned tables to publications |
| Date: | 2020-04-08 14:10:37 |
| Message-ID: | CA+HiwqHE=C2hxUgsvSh06D-2pVnz3T5ozZWyFR8CqkyGX9kJCg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 8, 2020 at 11:07 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> On Wed, Apr 8, 2020 at 9:21 PM Peter Eisentraut
> <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> > I think this is because the END { } section in PostgresNode.pm shuts
> > down all running instances in immediate mode, which doesn't save
> > coverage properly.
>
> Thanks for that tip. Appending the following at the end of the test
> file has fixed the coverage reporting for me.
The patch posted in the previous email has it, but I meant this by
"the following":
+
+$node_publisher->stop('fast');
+$node_subscriber1->stop('fast');
+$node_subscriber2->stop('fast');
--
Amit Langote
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Steele | 2020-04-08 14:24:19 | Re: Online checksums patch - once again |
| Previous Message | Juan José Santamaría Flecha | 2020-04-08 14:09:33 | Re: PG compilation error with Visual Studio 2015/2017/2019 |