Re: Making Bitmapsets be valid Nodes

On Mon, Nov 14, 2022 at 12:23 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> writes:
> > On 11.11.22 21:05, Tom Lane wrote:
> >> Attached is a cleaned-up version of Amit's patch v24-0003 at [2].
> >> I fixed the problems with not always tagging Bitmapsets, and changed
> >> the outfuncs/readfuncs logic so that Bitmapsets still print exactly
> >> as they did before (thus, this doesn't require a catversion bump).
>
> > This looks good to me.
>
> Pushed, thanks for looking.

Thanks a lot for this.

I agree that it may not be worthwhile to add an extra function call by
changing COPY_BITMAPSET_FIELD, etc. that is currently emitted by
gen_node_support.pl for any Bitmapset * / Relid struct members to
COPY_NODE_FIELD, etc.

--
Thanks, Amit Langote
EDB: http://www.enterprisedb.com