Re: Creating foreign key on partitioned table is too slow

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: "kato-sho(at)fujitsu(dot)com" <kato-sho(at)fujitsu(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, David Steele <david(at)pgmasters(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Creating foreign key on partitioned table is too slow
Date: 2020-08-21 02:20:33
Message-ID: CA+HiwqGPq+kpgCgb+JqDXropB6+srq8oUnE+CfU304gH96SjOw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Aug 20, 2020 at 10:50 AM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
On Thu, Aug 20, 2020 at 3:06 AM Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
> > On 2020-Aug-19, Amit Langote wrote:
> > > On Thu, Aug 6, 2020 at 4:25 PM kato-sho(at)fujitsu(dot)com
> > > <kato-sho(at)fujitsu(dot)com> wrote:
> > > > On Wednesday, August 5, 2020 9:43 AM I wrote:
> > > > > I'll report the result before the end of August .
> > > >
> > > > I test v2-0001-build-partdesc-memcxt.patch at 9a9db08ae4 and it is ok.
>
> Fwiw, I am fine with applying the memory-leak fix in all branches down
> to v12 if we are satisfied with the implementation.

I have revised the above patch slightly to introduce a variable for
the condition whether to use a temporary memory context.

--
Amit Langote
EnterpriseDB: http://www.enterprisedb.com

Attachment Content-Type Size
v3-0001-build-partdesc-memcxt.patch application/octet-stream 3.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message tsunakawa.takay@fujitsu.com 2020-08-21 02:53:42 RE: New statistics for tuning WAL buffer size
Previous Message Fujii Masao 2020-08-21 02:17:58 Re: Fix typo in procarrary.c